Add Custom Domains migration#188
Conversation
Greptile SummaryThis PR adds custom-domain proxy-rule migration between Appwrite projects. It introduces a
Confidence Score: 5/5Safe to merge; the only new finding is a cosmetic count mismatch in the pre-migration report that does not affect migration correctness. The core migration path — export, transfer, and import of proxy rules — is functionally correct. The one new finding (inflated rule count in reportDomains) affects only the progress estimate shown to the user, not the actual rules created on the destination. src/Migration/Sources/Appwrite.php (reportDomains) and src/Migration/Destinations/Appwrite.php (createRule redirect branch) warrant a second look before the E2E test run. Important Files Changed
Reviews (7): Last reviewed commit: "Merge branch 'add-smtp-migration' into a..." | Re-trigger Greptile |
…tom-domains-migration
- Transfer::extractServices match was missing GROUP_SETTINGS; callers hit the default 'No service group found' branch even though GROUP_SETTINGS_RESOURCES exists. - Destination's redirect-rule fanout called ProxyResourceType::FUNCTION() which the SDK generator renames to FUNCTIONMODEL() because FUNCTION is a PHP reserved keyword. Underlying value is still 'function'.
…tom-domains-migration
…tom-domains-migration
Summary
Resource::TYPE_RULEfor migrating custom-domain proxy rules.Sources/Appwrite) lists rules via the console SDK'sProxyservice, paginated with cursor.Destinations/Appwrite) dispatches to the SDK's four proxy-rule create endpoints (createAPIRule,createFunctionRule,createSiteRule,createRedirectRule) based on the rule'stype+deploymentResourceType..appwrite.networkrules are skipped — they're recreated automatically when the parent Function/Site is migrated.STATUS_WARNINGrather than aborting the migration, since the source must release the domain first.exportGroupDomainsin Firebase / NHost / JSON / CSV sources to satisfy the new abstract method.Test plan
testAppwriteMigrationCustomDomains(in appwrite/appwrite) passes