seq: optimize slow path loop by implementing AddAssign for ExtendedBigDecimal #10047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the "slow path" of
seqby replacing the allocation-heavy addition loop with in-place mutation.Currently, the
print_seqloop performs the following operation:It explicitly clones the increment (a potential BigInt allocation) on every iteration.
I have implemented
std::ops::AddAssign<&ExtendedBigDecimal>forExtendedBigDecimaland updatedseqto use:I reviewed the upstream
bigdecimalcrate and noticed that addassign_bigdecimal_ref currently contains aTODOand performs ato_owned()internally. Even with that upstream limitation, this PR provides immediate benefits.