fix(cp): always create dest dirs with owner write bit before fixing permissions#11318
Merged
RenjiSann merged 1 commit intouutils:mainfrom Mar 17, 2026
Merged
Conversation
|
GNU testsuite comparison: |
Collaborator
|
Thanks you for your contribution ! |
baa-ableton
force-pushed
the
fix/cp-readonly-source-dir
branch
from
d8be0bc to
da19515
Compare
Contributor
Author
|
@RenjiSann all done! |
Contributor
Author
|
@RenjiSann |
RenjiSann
force-pushed
the
fix/cp-readonly-source-dir
branch
from
da19515 to
7801bc0
Compare
Collaborator
|
I tried to fix the GNU test, but the issue seems to be present on other PRs as well, so I assume this change isn't the cause |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on a related bug (nushell#17548), I traced the root cause back to uu_cp itself.
When copying a read-only directory with -p -r, build_dir() creates the destination with the source's read-only permissions. This causes cp to fail with a permission error when it then tries to copy files into it.