fix: replace unsafe unwrap() calls with expect() for better error handling#11337
Open
mango766 wants to merge 1 commit intouutils:mainfrom
Open
fix: replace unsafe unwrap() calls with expect() for better error handling#11337mango766 wants to merge 1 commit intouutils:mainfrom
mango766 wants to merge 1 commit intouutils:mainfrom
Conversation
…dling - Replace unwrap() with expect() in validation.rs for binary path resolution - Replace unwrap() with expect() in uudoc.rs for command line argument parsing - Replace unwrap() with expect() in build.rs for locale processing tests This improves error messages and makes failures more descriptive when these operations fail unexpectedly.
|
GNU testsuite comparison: |
Contributor
|
|
Contributor
|
Note, these long comments #0 are helpful |
Contributor
|
I'm interested in enabling |
Contributor
|
Is it necessary to avoid |
Contributor
|
No. I meant allowing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces unsafe calls with throughout the coreutils codebase to provide better error handling and debugging information.
Changes
Error Handling Improvements
Safety Enhancements
Why This Matters
Testing