Skip to content

protect names against binary name#11378

Open
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:test-name
Open

protect names against binary name#11378
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:test-name

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Mar 18, 2026

Closes #11343 . Should reduce binary size too

@oech3 oech3 force-pushed the test-name branch 2 times, most recently from e418e35 to 81ec735 Compare March 18, 2026 03:10
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 18, 2026

Merging this PR will not alter performance

✅ 298 untouched benchmarks
⏩ 48 skipped benchmarks1


Comparing oech3:test-name (2f43bd3) with main (7609966)

Open in CodSpeed

Footnotes

  1. 48 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
Copy link
Contributor Author

oech3 commented Mar 18, 2026

Merging this PR will degrade performance by 37.71%

Too large perf drop

@oech3
Copy link
Contributor Author

oech3 commented Mar 18, 2026

I have no idea why is this bad for CPU perf.

@cakebaker cakebaker changed the title protest names against binary name protect names against binary name Mar 18, 2026
@oech3

This comment was marked as resolved.

@sylvestre
Copy link
Contributor

I have no idea why is this bad for CPU perf.

i guess a change in the compiler version or codspeed ?

@oech3
Copy link
Contributor Author

oech3 commented Mar 18, 2026

It did not happen at other PR. I guess this changes compiler's optimization.

@oech3 oech3 force-pushed the test-name branch 4 times, most recently from c3364a5 to 6a622d6 Compare March 18, 2026 08:38
@oech3
Copy link
Contributor Author

oech3 commented Mar 18, 2026

I think we need to uucore::localized_help_template lazy to improve help.

@oech3 oech3 force-pushed the test-name branch 2 times, most recently from 1b1e2aa to 79ef90b Compare March 18, 2026 09:18
@oech3 oech3 marked this pull request as ready for review March 18, 2026 09:18
@oech3

This comment was marked as outdated.

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/pipe-f is now passing!

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Congrats! The gnu test tests/tail/pipe-f is now passing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

all: name of individual binaries are hijacked by argv[0]

2 participants