shred: support character and block devices#12296
Open
gabrielhnf wants to merge 1 commit into
Open
Conversation
|
GNU testsuite comparison: |
2e2cc85 to
b0f36b7
Compare
Merging this PR will degrade performance by 19.55%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | cp_recursive_deep_tree[(120, 4)] |
562.5 KB | 699.2 KB | -19.55% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing gabrielhnf:fix-shred-enospc-and-unreadable-files (b0f36b7) with main (6a942ba)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12282 and #12283
shredwas rejecting character and block devices with "not a file" error, and doing nothing on them even when they were valid targets.wipe_fileusedpath.is_file()to validate the target, which returnsfalsefor all non-regular files, including devices. Additionally, the pass sequence was skipped entirely whenmetadata.len() == 0, which is always the case for devices.path.is_file()with a check that also accepts character and block devices on Unix--sizeargument was given--exactis enforced automatically for non-regular files since they have no meaningful block alignment