shred: handle '-' as stdout#12300
Open
gabrielhnf wants to merge 1 commit into
Open
Conversation
Merging this PR will improve performance by 13.72%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Memory | cp_recursive_deep_tree[(120, 4)] |
699.2 KB | 562.5 KB | +24.31% |
| ⚡ | Simulation | ls_recursive_balanced_tree[(6, 4, 15)] |
50.9 ms | 48.9 ms | +4.03% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing gabrielhnf:fix-shred-stdout-dash (bbb9c48) with main (d09f351)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
GNU testsuite comparison: |
xtqqczze
reviewed
May 15, 2026
| @@ -627,7 +627,16 @@ fn wipe_file( | |||
| force: bool, | |||
| ) -> UResult<()> { | |||
| // Get these potential errors out of the way first | |||
Contributor
There was a problem hiding this comment.
this comment should move down, or be removed
fb75c78 to
bbb9c48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12288
Resolve
-to/dev/fd/1on Unix systems, allowing shred to operate on whatever stdout is connected to. This matches the UNIX convention used by most coreutils tools.When stdout is a pipe or terminal, the existing file type validation naturally rejects it with "not a file".
This doesn't match GNU's "invalid file type", but feels out of scope for the issue.