yes: use as_encoded_bytes#12306
Conversation
Merging this PR will degrade performance by 12.08%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
|
please add a test to make sure we don't regress |
|
I don't know what letter corresponds with invalid utf8. |
|
GNU testsuite comparison: |
|
|
||
| #[test] | ||
| #[cfg(any(unix, target_os = "wasi"))] | ||
| fn test_non_utf8() { |
There was a problem hiding this comment.
@ChrisDenton I cannot write test working on Windows
I think the byte 0xff is never used in the UTF-8 encoding. https://manpages.ubuntu.com/manpages/stonking/man7/utf-8.7.html |
|
But I can't put it as args. |
Closes #12236