Skip to content

cp: set status code when encountering circular symbolic links #9757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Thanhphan1147 wants to merge 12 commits into
base: main
Choose a base branch
from
Open

cp: set status code when encountering circular symbolic links #9757

Thanhphan1147 wants to merge 12 commits into from
+30 −2

Conversation

@Thanhphan1147
Copy link

@Thanhphan1147 Thanhphan1147 commented Dec 20, 2025

Fixes #9710

Change from using the show_error! macro to the show! macro which correctly sets the status code.

Added a new test to validate this behavior.

sylvestre
sylvestre reviewed Dec 20, 2025
View reviewed changes
tests/by-util/test_cp.rs Outdated
ucmd.arg(source_dir)
.arg(target_dir)
.arg("-rL")
.fails_with_code(1);
Copy link
Contributor

@sylvestre sylvestre Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also verify the output

Copy link
Author

@Thanhphan1147 Thanhphan1147 Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the test to check for the output. I did not check for an exact match of the stderr since I think they might differ slightly depending on the OS and "Too many levels of symbolic links" should be a good enough indicator that the command is outputting what we expect I think.

Copy link
Author

@Thanhphan1147 Thanhphan1147 Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to make the test to complex and test for the full output for the different OSes so I updated the test to simply check for the string from walkdir.

Copy link
Author

@Thanhphan1147 Thanhphan1147 Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the tests again to include windows-specific syntax for the error message

@github-actions
Copy link

github-actions bot commented Dec 20, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/tty/tty-eof is no longer failing!

@github-actions
Copy link

github-actions bot commented Dec 26, 2025

GNU testsuite comparison:

Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

@github-actions
Copy link

github-actions bot commented Dec 29, 2025

GNU testsuite comparison:

Note: The gnu test tests/id/smack was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-no-root was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-root was skipped on 'main' but is now failing.

@github-actions
Copy link

github-actions bot commented Dec 29, 2025

GNU testsuite comparison:

Note: The gnu test tests/id/smack was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-no-root was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-root was skipped on 'main' but is now failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre Awaiting requested review from sylvestre

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cp -rL returns exit code 0 when encountering circular symbolic links error

2 participants

@Thanhphan1147 @sylvestre