feat: Expand safe directory traversal to all Unix platforms and fix related type conversions. #9792
+56
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elated type conversions.
|
GNU testsuite comparison: |
sylvestre
requested changes
Dec 23, 2025
Contributor
sylvestre
left a comment
sylvestre
left a comment
There was a problem hiding this comment.
plenty of jobs are failing, please fix them
- Use 'as u64' casts with clippy::unnecessary_cast suppression for st_nlink and st_ino to handle platform-specific type differences - Add TOCTOU (time-of-check time-of-use) to cspell dictionary Fixes compilation errors on FreeBSD, OpenBSD, and Android where libc types differ from Linux/macOS (st_nlink is u16, st_ino is u32). The cast is unnecessary on some platforms but required on others, hence the clippy suppression.
Resolved merge conflict in src/uu/du/src/du.rs by keeping the unix cfg guard (not target_os = "linux") to align with the PR's goal of expanding safe_traversal to all Unix platforms.
Contributor
|
Still a few job failures |
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: enable safe traversal on all Unix platforms
Expands the
safe_traversalmodule support fromtarget_os = "linux"tounix, enabling security improvements (specifically preventing TOCTOU races) on macOS and BSDs.Changes:
#[cfg(target_os = "linux")]with#[cfg(unix)]inuucore,du,chmod, andrm.src/uu/rm/src/platform/linux.rstounix.rsto reflect the broader platform support.safe_traversal.rsanddu.rsto handle platform-specific differences inlibctypes (e.g.,mode_t).Verification:
Verified with
cargo teston macOS.Closes #9747