cp: fix preserve-gid when canonicalize fails due to inaccessible parent dirs #9803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
Collaborator
Author
|
I was doing more research on this PR and the passing GNU test because of it, the test is supposed to make sure that the pid is preserved, but the issue is that the user that the GNU test uses for this test sets just happens to have the same GID as the file its testing so it just happens to work out. There is a permission flag in here that needs to be changed from the id of the user to a 0 or -1 somewhere to indicate that the gid should be preserved. Will add another follow up PR for this one |
Collaborator
Author
|
As a note for reviewers this one is quite difficult to make a rust test for that matches the gnu equivalent because I believe it requires root permissions, same as the GNU test. |
naoNao89
pushed a commit
to naoNao89/coreutils
that referenced
this pull request
Dec 31, 2025
…nt dirs (uutils#9803) Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
naoNao89
pushed a commit
to naoNao89/coreutils
that referenced
this pull request
Jan 1, 2026
…nt dirs (uutils#9803) Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going through all of the remaining tests and when trying to replicate the failure I was able to see after adding debugging logs that the command was failing silently. Narrowed it down to this function and then saw that this was failing to canonicalize this path when running as the gid 1000.