touch: use write-open + futimens on Unix to trigger IN_CLOSE_WRITE by mattsu2020 · Pull Request #9813 · uutils/coreutils

mattsu2020 · 2025-12-24T09:48:13Z

Summary

Make touch open regular files for write and call futimens on the fd (Unix only). This matches GNU touch behavior and ensures inotify emits IN_CLOSE_WRITE when timestamps are updated.

Motivation

Some inotify-based reloaders watch only IN_CLOSE_WRITE. With the current path-based timestamp update, touch emits only IN_ATTRIB, so those watchers miss the change. This caused infinite loops in downstream tests (e.g., 0 A.D. hotload tests on Ubuntu Questing).

Changes

On Unix, attempt OpenOptions::new().write(true) and call futimens on the fd for regular files.
Fallback to the existing set_file_times path-based update when open/futimens fails or the target is not a regular file.
Keep existing symlink handling intact.

Testing

cargo test -p uu_touch

Notes

Behavior is Unix-only and preserves current semantics on non-Unix platforms.

related
#9812

sylvestre · 2025-12-24T09:57:16Z

is it possible to add tests ? thanks

mattsu2020 · 2025-12-25T10:20:52Z

is it possible to add tests ? thanks

add

sylvestre · 2025-12-29T12:31:30Z

sorry, it needs to be rebased

github-actions · 2026-01-05T11:28:39Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions · 2026-01-10T06:31:00Z

GNU testsuite comparison:

Congrats! The gnu test tests/stty/bad-speed is now passing!

codspeed-hq · 2026-01-19T12:16:43Z

Merging this PR will not alter performance

✅ 288 untouched benchmarks
⏩ 42 skipped benchmarks¹

_{Comparing mattsu2020:bug_analystic (7a73d07) with main (1d113b5)}

42 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-01-19T12:36:38Z

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

sylvestre · 2026-02-10T21:27:44Z

+    let mtime_spec = TimeSpec::new(mtime.unix_seconds() as _, mtime.nanoseconds() as _);
+
+    futimens(&file, &atime_spec, &mtime_spec)
+        .map_err(|err| std::io::Error::from_raw_os_error(err as i32))


he conversion from nix::Error to std::io::Error is incorrect

sylvestre · 2026-02-10T21:28:13Z

+    #[cfg(unix)]
+    {
+        // Open write-only and use futimens to trigger IN_CLOSE_WRITE on Linux.
+        if !is_stdout && try_futimens_via_write_fd(path, atime, mtime).is_ok() {


Silent error swallowing with is_ok() loses information about why futimens failed.

sylvestre · 2026-02-10T21:28:40Z

+/// access and modification times on the open FD (not by path), which also
+/// triggers `IN_CLOSE_WRITE` on Linux when the FD is closed.
+fn try_futimens_via_write_fd(path: &Path, atime: FileTime, mtime: FileTime) -> std::io::Result<()> {
+    let metadata = fs::metadata(path)?;


Unnecessary metadata check before open. Opens file twice (metadata + open). Should check metadata after opening via file.metadata() to avoid TOCTOU and reduce syscalls.

sylvestre · 2026-02-10T21:28:56Z

+fn try_futimens_via_write_fd(path: &Path, atime: FileTime, mtime: FileTime) -> std::io::Result<()> {
+    let metadata = fs::metadata(path)?;
+    if !metadata.is_file() {
+        return Err(Error::other("not a regular file"));


please use translate!()

sylvestre · 2026-02-10T21:29:21Z

+    }
+
+    let file = OpenOptions::new().write(true).open(path)?;
+    let atime_spec = TimeSpec::new(atime.unix_seconds() as _, atime.nanoseconds() as _);


Unsafe type cast 'as _' for nanoseconds. Should explicitly cast to i32: atime.nanoseconds() as i32

github-actions · 2026-02-10T21:39:33Z

GNU testsuite comparison:

Congrats! The gnu test tests/pr/bounded-memory is no longer failing!

sylvestre · 2026-02-10T21:41:24Z

        uu_app,
    };

+    #[cfg(unix)]


Redundant import - std::fs is already imported unconditionally at line 26

github-actions · 2026-02-11T12:17:32Z

GNU testsuite comparison:

GNU test failed: tests/touch/not-owner. tests/touch/not-owner is passing on 'main'. Maybe you have to rebase?

github-actions · 2026-02-14T12:11:48Z

GNU testsuite comparison:

GNU test failed: tests/factor/t10. tests/factor/t10 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/factor/t34. tests/factor/t34 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/touch/not-owner. tests/touch/not-owner is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cut/cut-huge-range is now passing!
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

github-actions · 2026-02-18T09:07:19Z

GNU testsuite comparison:

GNU test failed: tests/rm/isatty. tests/rm/isatty is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/touch/not-owner. tests/touch/not-owner is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/cut/bounded-memory is no longer failing!
Note: The gnu test tests/cp/link-heap is now being skipped but was previously passing.

github-actions · 2026-02-18T09:19:55Z

GNU testsuite comparison:

Congrats! The gnu test tests/cut/bounded-memory is no longer failing!
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.
Note: The gnu test tests/unexpand/bounded-memory is now being skipped but was previously passing.

On Unix, try futimens through a write-opened file descriptor to trigger IN_CLOSE_WRITE semantics, and fall back to set_file_times when needed. Also adds a unit test for the futimens path and wires unix-only dependencies.

github-actions · 2026-02-21T18:59:37Z

GNU testsuite comparison:

GNU test failed: tests/cut/bounded-memory. tests/cut/bounded-memory is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/date/date-locale-hour is no longer failing!

This commit removes a trailing newline at the end of the test module in src/uu/touch/src/touch.rs to maintain consistent code formatting and eliminate unnecessary whitespace.

Replace deprecated nix::libc::O_NONBLOCK with the standard libc::O_NONBLOCK constant to fix compilation warnings and ensure compatibility with the latest nix crate version.

github-actions · 2026-02-23T00:46:21Z

GNU testsuite comparison:

Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/date/date-locale-hour is no longer failing!

Replace direct libc::O_NONBLOCK usage with nix::libc::O_NONBLOCK to maintain consistency with the nix crate imports and avoid potential cross-platform compatibility issues.

github-actions · 2026-02-23T01:04:31Z

GNU testsuite comparison:

Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)

sylvestre · 2026-02-26T20:26:12Z

@mattsu2020 sorry it took forever but it fails with:


error[E0308]: arguments to this function are incorrect
   --> src/uu/touch/src/touch.rs:625:22
    |
625 |     let atime_spec = TimeSpec::new(atime_sec, atime_nsec);
    |                      ^^^^^^^^^^^^^ ---------  ---------- expected `i32`, found `i64`
    |                                    |
    |                                    expected `i32`, found `i64`
    |
note: associated function defined here
   --> /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/nix-0.30.1/src/sys/time.rs:356:18
    |
356 |     pub const fn new(seconds: time_t, nanoseconds: timespec_tv_nsec_t) -> Self {
    |                  ^^^
help: you can convert an `i64` to an `i32` and panic if the converted value doesn't fit
    |
625 |     let atime_spec = TimeSpec::new(atime_sec.try_into().unwrap(), atime_nsec);
    |                                             ++++++++++++++++++++
help: you can convert an `i64` to an `i32` and panic if the converted value doesn't fit
    |
625 |     let atime_spec = TimeSpec::new(atime_sec, atime_nsec.try_into().unwrap());
    |                                                         ++++++++++++++++++++

error[E0308]: arguments to this function are incorrect
   --> src/uu/touch/src/touch.rs:626:22
    |
626 |     let mtime_spec = TimeSpec::new(mtime_sec, mtime_nsec);
    |                      ^^^^^^^^^^^^^ ---------  ---------- expected `i32`, found `i64`
    |                                    |
    |                                    expected `i32`, found `i64`
    |
note: associated function defined here
   --> /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/nix-0.30.1/src/sys/time.rs:356:18
    |
356 |     pub const fn new(seconds: time_t, nanoseconds: timespec_tv_nsec_t) -> Self {
    |                  ^^^
help: you can convert an `i64` to an `i32` and panic if the converted value doesn't fit
    |
626 |     let mtime_spec = TimeSpec::new(mtime_sec.try_into().unwrap(), mtime_nsec);
    |                                             ++++++++++++++++++++
help: you can convert an `i64` to an `i32` and panic if the converted value doesn't fit
    |
626 |     let mtime_spec = TimeSpec::new(mtime_sec, mtime_nsec.try_into().unwrap());
    |                                                         ++++++++++++++++++++

For more information about this error, try `rustc --explain E0308`.

sylvestre · 2026-03-04T22:34:31Z

i merged it!

mattsu2020 · 2026-03-04T22:55:52Z

thanks

sylvestre reviewed Dec 24, 2025

View reviewed changes

Comment thread src/uu/touch/src/touch.rs Outdated

sylvestre reviewed Dec 24, 2025

View reviewed changes

Comment thread src/uu/touch/src/touch.rs

mattsu2020 requested a review from sylvestre January 5, 2026 10:16

sylvestre reviewed Feb 10, 2026

View reviewed changes

mattsu2020 force-pushed the bug_analystic branch from d741ba8 to 8e88196 Compare February 18, 2026 09:11

touch: set file times via futimens on a write fd

d0822d6

On Unix, try futimens through a write-opened file descriptor to trigger IN_CLOSE_WRITE semantics, and fall back to set_file_times when needed. Also adds a unit test for the futimens path and wires unix-only dependencies.

sylvestre force-pushed the bug_analystic branch from 8e88196 to d0822d6 Compare February 21, 2026 18:51

mattsu2020 added 2 commits February 23, 2026 09:30

Remove trailing whitespace from touch.rs test module

0a802d1

This commit removes a trailing newline at the end of the test module in src/uu/touch/src/touch.rs to maintain consistent code formatting and eliminate unnecessary whitespace.

fix: Use libc::O_NONBLOCK instead of nix::libc::O_NONBLOCK in touch.rs

affaa76

Replace deprecated nix::libc::O_NONBLOCK with the standard libc::O_NONBLOCK constant to fix compilation warnings and ensure compatibility with the latest nix crate version.

fix: Use O_NONBLOCK constant from nix crate instead of libc

7a73d07

Replace direct libc::O_NONBLOCK usage with nix::libc::O_NONBLOCK to maintain consistency with the nix crate imports and avoid potential cross-platform compatibility issues.

sylvestre closed this Mar 4, 2026

mattsu2020 deleted the bug_analystic branch March 4, 2026 22:55

Uh oh!

Conversation

mattsu2020 commented Dec 24, 2025

Summary

Motivation

Changes

Testing

Notes

Uh oh!

Uh oh!

Uh oh!

sylvestre commented Dec 24, 2025

Uh oh!

mattsu2020 commented Dec 25, 2025

Uh oh!

sylvestre commented Dec 29, 2025

Uh oh!

github-actions Bot commented Jan 5, 2026

Uh oh!

github-actions Bot commented Jan 10, 2026

Uh oh!

codspeed-hq Bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

github-actions Bot commented Jan 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 11, 2026

Uh oh!

github-actions Bot commented Feb 14, 2026

Uh oh!

github-actions Bot commented Feb 18, 2026

Uh oh!

github-actions Bot commented Feb 18, 2026

Uh oh!

github-actions Bot commented Feb 21, 2026

Uh oh!

github-actions Bot commented Feb 23, 2026

Uh oh!

github-actions Bot commented Feb 23, 2026

Uh oh!

sylvestre commented Feb 26, 2026

Uh oh!

sylvestre commented Mar 4, 2026

Uh oh!

mattsu2020 commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

codspeed-hq Bot commented Jan 19, 2026 •

edited

Loading