Skip to content

test(date): validate locale formats via runtime expansion #9831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
naoNao89 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test(date): validate locale formats via runtime expansion #9831

naoNao89 wants to merge 1 commit into from
+110 −34

Conversation

@naoNao89
Copy link
Contributor

@naoNao89 naoNao89 commented Dec 25, 2025

Tried to reproduce on macOS 26 but tests pass fine locally.

Fails on CI's macOS 15.7.2 though. Turns out nl_langinfo returns different format codes across macOS versions. Fixed by validating the expanded output instead of checking literal format strings.

Fixes #9654

@naoNao89 naoNao89 force-pushed the fix/macos-locale-tests-9654 branch 2 times, most recently from 933541a to 8ab3dd6 Compare December 25, 2025 00:58
@naoNao89 naoNao89 marked this pull request as draft December 25, 2025 01:01
@naoNao89 naoNao89 force-pushed the fix/macos-locale-tests-9654 branch from 8ab3dd6 to 0caeab6 Compare December 25, 2025 01:12
@github-actions
Copy link

github-actions bot commented Dec 25, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-debug-keys is no longer failing!

@naoNao89 naoNao89 force-pushed the fix/macos-locale-tests-9654 branch 2 times, most recently from 42a604f to 30f84e7 Compare December 25, 2025 10:42
@github-actions
Copy link

github-actions bot commented Dec 25, 2025

GNU testsuite comparison:

GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?

@naoNao89 naoNao89 force-pushed the fix/macos-locale-tests-9654 branch from 30f84e7 to 2582fed Compare December 26, 2025 00:52
@github-actions
Copy link

github-actions bot commented Dec 26, 2025

GNU testsuite comparison:

Note: The gnu test tests/pr/pr-tests was skipped on 'main' but is now failing.

@naoNao89 naoNao89 force-pushed the fix/macos-locale-tests-9654 branch from 2582fed to bf9126c Compare December 26, 2025 11:12
@github-actions
Copy link

github-actions bot commented Dec 26, 2025

GNU testsuite comparison:

GNU test failed: tests/tty/tty-eof. tests/tty/tty-eof is passing on 'main'. Maybe you have to rebase?

@naoNao89 naoNao89 force-pushed the fix/macos-locale-tests-9654 branch 2 times, most recently from 33a076a to 3978c5c Compare December 27, 2025 23:36
@github-actions
Copy link

github-actions bot commented Dec 27, 2025

GNU testsuite comparison:

GNU test failed: tests/date/date-locale-hour. tests/date/date-locale-hour is passing on 'main'. Maybe you have to rebase?

@naoNao89 naoNao89 force-pushed the fix/macos-locale-tests-9654 branch from 3978c5c to f1c95e1 Compare December 28, 2025 03:02
@github-actions
Copy link

github-actions bot commented Dec 28, 2025

GNU testsuite comparison:

GNU test failed: tests/date/date-locale-hour. tests/date/date-locale-hour is passing on 'main'. Maybe you have to rebase?

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 28, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9831 will not alter performance

Comparing naoNao89:fix/macos-locale-tests-9654 (3834585) with main (1aac2ec)1

Summary

✅ 127 untouched
⏩ 6 skipped2

Footnotes

  1. No successful run was found on main (dd08296) during the generation of this report, so 1aac2ec was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@naoNao89
test(date): use parse_date for test helper timestamp
3834585 
Replace manual jiff::civil::date construction with parse_date
in expand_format_with_test_date helper to ensure proper
timestamp initialization for strtime formatting.

Fixes uutils#9654
@naoNao89 naoNao89 force-pushed the fix/macos-locale-tests-9654 branch from f1c95e1 to 3834585 Compare December 28, 2025 03:41
@github-actions
Copy link

github-actions bot commented Dec 28, 2025

GNU testsuite comparison:

GNU test failed: tests/cp/cp-mv-enotsup-xattr. tests/cp/cp-mv-enotsup-xattr is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/csplit/csplit-io-err was skipped on 'main' but is now failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@naoNao89