perf(date): wrap stdout in BufWriter to improve batch processing #9994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrazyRoka
force-pushed
the
date-optimize-println
branch
from
d6708e5 to
b0afcf4
Compare
CrazyRoka
force-pushed
the
date-optimize-println
branch
from
b0afcf4 to
f0238dc
Compare
Contributor
Author
|
Some CodSpeed benchmarks are showing ~30% performance improvement when system calls are included in the measurement (link): 
|
sgmarz
pushed a commit
to sgmarz/coreutils
that referenced
this pull request
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a performance bottleneck when processing large numbers of dates (e.g., using
date -f large_file.txt).Previously, the main loop used
println!, which locks and flushesstdouton every iteration. This change wrapsstdoutin aBufWriterand useswriteln!, significantly improving throughput for batch operations.