Skip to content

fix: vmstat cache column should include SReclaimable #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Deepak8858 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: vmstat cache column should include SReclaimable #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f2c9ed
fix: vmstat cache column should include SReclaimable (closes #389)
Adityasingh-upkgs Mar 20, 2026
1c1cd09
Merge branch 'main' into fix/issue-389-vmstat-cache-info
Krysztal112233 Mar 26, 2026
3c7d6b1
Merge branch 'main' into fix/issue-389-vmstat-cache-info
Bluemangoo Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/uu/vmstat/src/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ pub struct Meminfo {
pub mem_available: bytesize::ByteSize,
pub buffers: bytesize::ByteSize,
pub cached: bytesize::ByteSize,
pub s_reclaimable: bytesize::ByteSize,
pub swap_cached: bytesize::ByteSize,
pub active: bytesize::ByteSize,
pub inactive: bytesize::ByteSize,
Expand All @@ -226,6 +227,8 @@ impl Meminfo {
bytesize::ByteSize::from_str(proc_map.get("MemAvailable").unwrap()).unwrap();
let buffers = bytesize::ByteSize::from_str(proc_map.get("Buffers").unwrap()).unwrap();
let cached = bytesize::ByteSize::from_str(proc_map.get("Cached").unwrap()).unwrap();
let s_reclaimable =
bytesize::ByteSize::from_str(proc_map.get("SReclaimable").unwrap()).unwrap();
let swap_cached =
bytesize::ByteSize::from_str(proc_map.get("SwapCached").unwrap()).unwrap();
let active = bytesize::ByteSize::from_str(proc_map.get("Active").unwrap()).unwrap();
Expand All @@ -238,6 +241,7 @@ impl Meminfo {
mem_available,
buffers,
cached,
s_reclaimable,
swap_cached,
active,
inactive,
Expand Down
5 changes: 4 additions & 1 deletion src/uu/vmstat/src/picker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,10 @@ fn get_memory_info(
}

let buffer = with_unit(memory_info.buffers.as_u64(), matches);
let cache = with_unit(memory_info.cached.as_u64(), matches);
let cache = with_unit(
(memory_info.cached + memory_info.s_reclaimable).as_u64(),
matches,
);

vec![
(len, format!("{swap_used}")),
Expand Down
Loading