feat: add TOTP/MFA support for local controller auth#10
Open
mi-skam wants to merge 2 commits intovedanta:mainfrom
Open
feat: add TOTP/MFA support for local controller auth#10mi-skam wants to merge 2 commits intovedanta:mainfrom
mi-skam wants to merge 2 commits intovedanta:mainfrom
Conversation
UDM controllers with SSO accounts that have MFA enabled return HTTP 499 requiring a TOTP token. This adds UNIFI_CONTROLLER_TOTP env var support to pass the token during login, and proper error messaging when MFA is required but no token is provided. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The status command called login() directly, bypassing the session cache. This forced a fresh auth on every invocation, which breaks MFA accounts since a new TOTP code would be needed each time. Changed to ensure_authenticated() which reuses the cached session when valid. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UNIFI_CONTROLLER_TOTPenv var to pass a TOTP code during local controller loginContext
UDM controllers where the admin account has MFA enabled (via UI.com SSO) reject
/api/auth/loginwith status 499 andMFA_AUTH_REQUIRED. The fix includes thetokenfield in the login payload whenUNIFI_CONTROLLER_TOTPis set.Once authenticated, the session cookie is cached (existing behavior), so the TOTP is only needed for the initial login.
Test plan
ui local health,ui local devices list,ui local clients list,ui local networks listall work after auth🤖 Generated with Claude Code