perf: precompute time unit constants#293
Open
wyf027 wants to merge 1 commit into
Open
Conversation
Replace runtime multiplication chains with literal millisecond values for each unit constant. Fixes vercel#271
wyf027
force-pushed
the
perf/precompute-time-constants-271
branch
from
2e12d33 to
c16fd97
Compare
|
V8 already do constant folding, so it's useless, no perf improvement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
m,h,d,w,y, andmoFixes #271
Test plan
npm test— 167 passing