Remove Wondershaper upload rate limit for Google API traffic in AoU#397
Closed
yonghaoy wants to merge 4 commits into
Closed
Remove Wondershaper upload rate limit for Google API traffic in AoU#397yonghaoy wants to merge 4 commits into
yonghaoy wants to merge 4 commits into
Conversation
…ogle APIs Placeholder commit for tracking the security approval process to exempt Google API traffic from the Wondershaper upload rate limit in AoU apps. Implementation will follow once approval is granted. Jira: PHP-148769 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds the aou-sas app with build-time setup in the Dockerfile (packages, gcsfuse, gcloud SDK, user creation, SAS config, Apache proxy), a runtime startup script for volume-dependent steps, Mikey Secrets integration for SAS license delivery, and removes initializeCommand from devcontainers. Jira: PHP-148769 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit d8edfc7.
…shaper rate limit Add a wrapper entrypoint script that runs alongside wondershaper and adds tc filter exemptions for: - restricted.googleapis.com (199.36.153.4/30): already guarded by VPC Service Perimeter, rate limiting is redundant - Internal VPC traffic (10.0.0.0/8): covers Dataproc master-to-worker communication, which is intra-cluster and not internet egress Applied to all 5 AoU apps via a shared script in aou-common. Jira: PHP-148769 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
restricted.googleapis.com(199.36.153.4/30) traffic from Wondershaper upload rate limiting in AoU Workbench appsProblem
Wondershaper currently rate-limits all upload traffic indiscriminately from the master node, including:
restricted.googleapis.com— the VPC Service Controls restricted VIP used for all Google API access (GCS, BigQuery, etc.) within the security perimeterThis causes:
restricted.googleapis.comare throttled, causing cascading pipeline failures. Hail is a core genomics analysis tool and a primary reason researchers use the platform.Proposed Changes
1. Exempt
restricted.googleapis.com(199.36.153.4/30)Bypass the upload rate limit for traffic destined to the restricted Google API VIP. This is the only Google API endpoint reachable from within the VPC Service Perimeter.
2. Exempt master-to-worker node traffic
Bypass the upload rate limit for traffic from the Dataproc master node (where wondershaper runs) to worker nodes on the same VPC subnet. This is internal cluster communication, not egress.
Why This Is Low Risk
restricted.googleapis.com
restricted.googleapis.comare scoped to the service perimeter. A user cannot access any Google Cloud resource outside the perimeter — the request is denied at the platform level regardless of bandwidth.restricted.googleapis.comis the most locked-down VIP. Unlikeprivate.googleapis.com, the restricted VIP only allows access to APIs that are supported by VPC Service Controls. This is the VIP specifically designed for high-security environments.Master-to-worker traffic
Defense-in-depth summary
Test plan
199.36.153.4/30from upload rate limiting🤖 Generated with Claude Code