Skip to content

only mark room read when app is active #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viktorstrate merged 1 commit into from
Jun 2, 2026
Merged

only mark room read when app is active #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Mactrix/Views/ChatView/ChatView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,14 @@ struct TimelineGroupView: View {
}
}

private struct TimelineReadKey: Equatable {
let count: Int
let active: Bool
}

struct ChatJoinedRoom: View {
@Environment(AppState.self) private var appState
@Environment(\.appearsActive) private var appearsActive
@Bindable var timeline: LiveTimeline

var room: LiveRoom {
Expand Down Expand Up @@ -57,10 +63,10 @@ struct ChatJoinedRoom: View {
Logger.viewCycle.error("failed to mark room as recently visited: \(error)")
}
}
.task(id: timeline.timelineItems.count, priority: .background) {
.task(id: TimelineReadKey(count: timeline.timelineItems.count, active: appearsActive), priority: .background) {
guard appearsActive else { return }
do {
try await Task.sleep(for: .seconds(1))

Logger.viewCycle.debug("Mark room as read")
try await timeline.timeline?.markAsRead(receiptType: .read)
} catch is CancellationError {
Expand Down
Loading