Skip to content

chore: add tony's eslint rules#1561

Closed
NoiseFan wants to merge 3 commits intovitejs:mainfrom
NoiseFan:chore/eslint
Closed

chore: add tony's eslint rules#1561
NoiseFan wants to merge 3 commits intovitejs:mainfrom
NoiseFan:chore/eslint

Conversation

@NoiseFan
Copy link
Copy Markdown
Contributor

@NoiseFan NoiseFan commented Feb 7, 2026

为什么会开启这个pr?

vitepress-plugin-llms 这个 vitepress 插件仅需在英文仓库使用,下游仓库无需开启。
在合并上游仓库的合并时,有可能误合并进来,期望使用自动化的流程进行检查。

具体可参考:
vitest-dev/docs-cn#690
vitest-dev/docs-cn#921

修改范围

  • 添加 eslint 配置
    • 使用 tony 的 eslint 配置
    • 忽略了所有 md 文件的错误(上游仓库也未处理这些错误)
  • 添加禁用 vitepress-plugin-llms 规则
  • 修复项目中 lint 错误
  • 添加 autofix CI

TODO

  • 需要 admin 权限的管理员开启 autofix 应用,详见下文 autofix 的评论

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 7, 2026

@NoiseFan is attempting to deploy a commit to the vuejs Team on Vercel.

A member of the Team first needs to authorize it.

@autofix-troubleshooter
Copy link
Copy Markdown

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

@NoiseFan
Copy link
Copy Markdown
Contributor Author

NoiseFan commented Feb 7, 2026

这个项目合并我遇到了一些问题,无论是 dev 还是 main 分支,都无法正确的完成 build 命令。

整个 pr 做下来感觉思路不太对,整个重心应该放在 lint 上,而不是格式上。(p.s. 但是项目中有好多手写的 bug,不确定是否正在使用,而且还忍不住改)

Comment thread eslint.config.ts
'regexp/no-super-linear-backtracking': 'off',
},
ignores: [
'**/*.md',
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改动还是太大了,这个目录下应该也可以跳过
Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我理解还好都是一些格式上的问题。对于功能并没什么改动。

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果和原仓库差异过大,以后上游同步回来 diff 会很大。

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不好意思了,可能还是先考虑关闭好了。为了这么小的提示,这么大的变更应该划不来。等后面有额外场景需要考虑的时候,我再来 reopen 这个,做接入好了。

@thinkasany thinkasany closed this Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants