Skip to content

fix: clear fetch error when zip is successfully loaded via drop #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hi-ogawa merged 2 commits into from
Mar 31, 2026
Merged

fix: clear fetch error when zip is successfully loaded via drop #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff47db0
fix: clear fetch error when zip is successfully loaded via drop
hi-ogawa Mar 31, 2026
3778ab0
test: add e2e for fetch error recovery via drop
hi-ogawa Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions e2e/basic.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@ test("file input", async ({ page }) => {
await testHtmlReport(page);
});

test("fetch error clears on drop recovery", async ({ page }) => {
await page.goto("/?url=http://localhost:1/test.zip");
await expect(page.getByTestId("fetch-error")).toContainText("likely blocked by CORS");
await page.locator('input[type="file"]').setInputFiles("docs/assets/vitest-html-reporter.zip");
await expect(page.getByTestId("fetch-error")).not.toBeVisible();
await testHtmlReport(page);
});

async function testHtmlReport(page: Page) {
await expect(page.getByTestId("status")).toContainText("Cached 7 files");
const frame = page.frameLocator("iframe");
Expand Down
6 changes: 5 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,10 @@
function FetchError({ error }) {
return h(
"div",
{ style: { textAlign: "center", fontSize: "0.85rem", color: "#c00", marginTop: "1rem" } },
{
"data-testid": "fetch-error",
style: { textAlign: "center", fontSize: "0.85rem", color: "#c00", marginTop: "1rem" },
},
h("div", null, error.message),
h(
"div",
Expand Down Expand Up @@ -238,6 +241,7 @@
}
setFileCount(count);
setStatusMsg(`Cached ${count} files. Loading...`);
setFetchError(null);
setLoaded(true);
}

Expand Down
Loading