Conversation
sveneberth
left a comment
sveneberth
left a comment
There was a problem hiding this comment.
Please resolve the conflicts.
Can you integrate a pre-commit-hook and GH Action to enforce these styles?
| <script setup> | ||
| import { onBeforeMount, watch, reactive } from 'vue'; | ||
| import ShopOrderStepper from './ShopOrderStepper.vue' | ||
| import { onBeforeMount, watch, reactive } from "vue" |
There was a problem hiding this comment.
Just a personal option. If the prettier does his job i don't really case. But I hate these spaces around. Any reason to have theses? What's the industry standard?
There was a problem hiding this comment.
this is industry standard in JS and i wont change it cuz i am very used to this conventions and this makes it easier for me to identify the imports
There was a problem hiding this comment.
JS != Python !!!!
| "bracketSameLine": false, | ||
| "arrowParens": "always", | ||
| "trailingComma": "none" | ||
| "trailingComma": "none", |
There was a problem hiding this comment.
Please use always trailing commas. That totally bad in combination with git history. Adding a new element means you change always two lines (the last needs the comma)
There was a problem hiding this comment.
i agree didnt check that one. and not sure why is it on none. probably we need to talk to AK again, as this config was made by him in the utils
There was a problem hiding this comment.
Aren't singleQuotes the default too?
There was a problem hiding this comment.
nope default in JS from the most common conventions are double quotes. we agreed on double quotes as well
2 participants
#22