Conversation
| export ND_CONFIGFILE=/var/lib/navidrome/navidrome.toml | ||
| exec chpst -u _navidrome:_navidrome navidrome |
There was a problem hiding this comment.
| export ND_CONFIGFILE=/var/lib/navidrome/navidrome.toml | |
| exec chpst -u _navidrome:_navidrome navidrome | |
| exec chpst -u _navidrome:_navidrome navidrome ${OPTS:- --configfile "/etc/navidrome/navidrome.toml"} |
Its always better to match upstream default locations and services (https://github.com/navidrome/navidrome/blob/4570dec675f904aa0cecd09b2c842685b762527e/contrib/navidrome.service#L14). Config files belong in /etc.
srcpkgs/navidrome/template
Outdated
| post_install() { | ||
| vlicense LICENSE | ||
| vmkdir var/lib/navidrome | ||
| vcopy release/linux/navidrome.toml var/lib/navidrome/navidrome.toml |
There was a problem hiding this comment.
| vcopy release/linux/navidrome.toml var/lib/navidrome/navidrome.toml | |
| vinstall release/linux/navidrome.toml 644 etc/navidrome |
srcpkgs/navidrome/template
Outdated
| } | ||
|
|
||
| post_install() { | ||
| vlicense LICENSE |
There was a problem hiding this comment.
If this is GPL, the license file doesn't need to be installed.
srcpkgs/navidrome/template
Outdated
| revision=1 | ||
| build_style=go | ||
| go_import_path=github.com/navidrome/navidrome | ||
| go_ldflags=" -X github.com/navidrome/navidrome/consts.gitSha=e7c7cba87374ebe1bace57271bc5e8cf731b7a6e -X github.com/navidrome/navidrome/consts.gitTag=v${version}" |
There was a problem hiding this comment.
Things like the commit will end up being outdated, either don't set it or set it to the version.
srcpkgs/navidrome/template
Outdated
| go_import_path=github.com/navidrome/navidrome | ||
| go_ldflags=" -X github.com/navidrome/navidrome/consts.gitSha=e7c7cba87374ebe1bace57271bc5e8cf731b7a6e -X github.com/navidrome/navidrome/consts.gitTag=v${version}" | ||
| go_build_tags="netgo,sqlite_fts5" | ||
| hostmakedepends="nodejs pkg-config sqlite-devel taglib-devel" |
There was a problem hiding this comment.
sqlite-devel taglib-devel sound like they belong in makedepends.
|
Ran new changes both on x86_64 glibc and aarch64 musl, works as expected. |
| @@ -0,0 +1,7 @@ | |||
| #!/usr/bin/env sh | |||
There was a problem hiding this comment.
It's probably safer to just go with the #!/bin/sh shebang. You can inspect other run files in Void for that.
Testing the changes
New package
Local build testing