fix: version-gate conditionalCreate/conditionalBranchCreate for Angular 19 support#106
Merged
Brooooooklyn merged 1 commit intomainfrom Mar 13, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
…ar 19 support Angular 19 does not have ɵɵconditionalCreate/ɵɵconditionalBranchCreate runtime instructions (introduced in Angular 20). When angularVersion < 20, emit ɵɵtemplate instead for @if/@switch blocks. Also wire angularVersion from PluginOptions through to the compiler pipeline. Closes #105 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Brooooooklyn
force-pushed
the
fix/angular-version-gating-conditional-create
branch
from
a5ebb8c to
408e8da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Angular 19 does not have ɵɵconditionalCreate/ɵɵconditionalBranchCreate
runtime instructions (introduced in Angular 20). When angularVersion < 20,
emit ɵɵtemplate instead for @if/@switch blocks. Also wire angularVersion
from PluginOptions through to the compiler pipeline.
Closes #105
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Note
Medium Risk
Changes codegen for
@if/@switchcreate ops based on a new Angular-version flag; incorrect version propagation could generate runtime-incompatible instructions for a given target.Overview
Adds Angular v20 feature detection for
ɵɵconditionalCreate/ɵɵconditionalBranchCreateand version-gates control-flow create op emission: when targeting Angular < 20,@if/@switchblocks now emitɵɵtemplateinstead of the v20-only conditional create instructions.Wires an optional
angularVersionthrough the ingest/compilation pipeline (including the Vite pluginPluginOptions→TransformOptions) and adds integration tests + snapshots to verify Angular 19 vs default (latest) output.Written by Cursor Bugbot for commit 408e8da. This will update automatically on new commits. Configure here.