Skip to content

fix(create): replace deprecated @tanstack/create-start with @tanstack/cli#1259

Open
jong-kyung wants to merge 2 commits intovoidzero-dev:mainfrom
jong-kyung:fix/tanstack-start-deprecated-template
Open

fix(create): replace deprecated @tanstack/create-start with @tanstack/cli#1259
jong-kyung wants to merge 2 commits intovoidzero-dev:mainfrom
jong-kyung:fix/tanstack-start-deprecated-template

Conversation

@jong-kyung
Copy link
Copy Markdown
Contributor

Summary

  • Replace deprecated @tanstack/create-start with @tanstack/cli create when running vp create @tanstack/start
  • Add create subcommand prepend in autoFixRemoteTemplateCommand (following existing sv pattern)
  • Keep --no-install, --no-toolchain, --no-git (monorepo) auto-fix flags

Closes #1238

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 1, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit e73ac3c
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69cd2f5d8cac480008fb19ff

@jong-kyung
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

templateInfo.args.push('--no-toolchain');

P1 Badge Drop unsupported --no-toolchain argument

Every vp create @tanstack/start invocation now appends --no-toolchain to @tanstack/cli create. The TanStack CLI tanstack create reference documents --toolchain <id>, --no-git, and --no-install, but not --no-toolchain; with strict option parsing this turns into an unknown-option error and can abort scaffolding before project creation.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +191 to 195
if (scope === '@tanstack' && name === 'start') {
return `@tanstack/cli${version}`;
}

return `${scope}/create-${name}${version}`;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve direct @tanstack/cli template names

This migration makes @tanstack/cli the canonical package, but scoped names that do not start with create- are still rewritten to @scope/create-*. As a result, vp create @tanstack/cli -- ... is converted to @tanstack/create-cli, which fails package resolution even though the real package exists. Add a pass-through for @tanstack/cli (including versioned inputs) before the default scoped rewrite.

Useful? React with 👍 / 👎.

@jong-kyung
Copy link
Copy Markdown
Contributor Author

jong-kyung commented Apr 1, 2026

💡 Codex Review

templateInfo.args.push('--no-toolchain');

P1 Badge Drop unsupported --no-toolchain argument
Every vp create @tanstack/start invocation now appends --no-toolchain to @tanstack/cli create. The TanStack CLI tanstack create reference documents --toolchain <id>, --no-git, and --no-install, but not --no-toolchain; with strict option parsing this turns into an unknown-option error and can abort scaffolding before project creation.

ℹ️ About Codex in GitHub

--no-toolchain is a supported flag. Running pnpm dlx @tanstack/cli create --help confirms it:

--no-toolchain  skip toolchain selection
스크린샷 2026-04-01 오후 9 53 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace create template @tanstack/start with @tanstack/cli create

2 participants