fix(create): add vp create e2e tests and fix yarn/bun migration bugs#1317
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 7, 2026
Merged
fix(create): add vp create e2e tests and fix yarn/bun migration bugs#1317graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fengmk2
force-pushed
the
add-vp-create-e2e
branch
from
b6bb893 to
fe223c7
Compare
fengmk2
force-pushed
the
add-vp-create-e2e
branch
from
79206b2 to
a938cf5
Compare
fengmk2
changed the title
vp create across all templates and package managers
fengmk2
force-pushed
the
add-vp-create-e2e
branch
from
7de2e6c to
174331e
Compare
fengmk2
changed the title
fengmk2
changed the title
cpojer
approved these changes
Apr 7, 2026
Merge activity
|
…1317) ## Summary Motivated by #1297 the `.yarnrc` template fix revealed that `vp create` had no e2e test coverage, making it easy for template bugs to ship undetected. - Add a new GitHub Actions workflow (`test-vp-create.yml`) that e2e tests `vp create` across all 3 built-in templates (monorepo, application, library) and all 4 package managers (pnpm, npm, yarn, bun) — 12 test combinations - Fix bun monorepo migration writing empty `catalog` with dangling `catalog:` references when using `file:` protocol - Fix yarn standalone projects missing `.yarnrc.yml` with `nodeLinker: node-modules` - Pass `--no-frozen-lockfile` from `vp create` in CI so yarn Berry can create fresh lockfiles ## Changes ### New: `vp create` e2e test workflow - Uses the same tgz-packaging approach as ecosystem-ci: build → pack → install vp from tgz → run `vp create` with `VP_OVERRIDE_PACKAGES`/`VP_VERSION` pointing to local packages - Each test verifies: project structure, correct lockfile, `vite-plus@0.0.0` installed, `vp check`, and build/test commands - Monorepo tests run `vp run ready` twice and assert 100% cache hit on the second run - Triggered on push to main (path-filtered), PRs with `test: create-e2e` label, or create-related file changes ### Fix: bun monorepo catalog with `file:` protocol - `rewriteBunCatalog()` unconditionally set all overrides to `catalog:` but skipped `file:` entries from the catalog, leaving unresolvable references - Now uses `file:` paths directly in overrides when the value starts with `file:` ### Fix: yarn standalone projects - `rewriteYarnrcYml()` now sets `nodeLinker: node-modules` when absent (yarn 4 defaults to PnP) - `rewriteStandaloneProject()` now calls `rewriteYarnrcYml()` for yarn projects (previously only called for monorepos) - `vp create` passes `--no-frozen-lockfile` to `vp install` in CI environments ## Test plan - [x] All 12 matrix jobs pass in CI (3 templates × 4 package managers) - [x] Existing migration tests pass (`vp test run packages/cli/src/migration/`) - [x] New `bun-catalog-file-protocol.spec.ts` test verifies the bun override fix 🤖 Generated with [Claude Code](https://claude.com/claude-code)
graphite-app
bot
force-pushed
the
add-vp-create-e2e
branch
from
365569e to
f47d2a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivated by #1297 the
.yarnrctemplate fix revealed thatvp createhad no e2e test coverage, making it easy for template bugs to ship undetected.test-vp-create.yml) that e2e testsvp createacross all 3 built-in templates (monorepo, application, library) and all 4 package managers (pnpm, npm, yarn, bun) — 12 test combinationscatalogwith danglingcatalog:references when usingfile:protocol.yarnrc.ymlwithnodeLinker: node-modules--no-frozen-lockfilefromvp createin CI so yarn Berry can create fresh lockfilesChanges
New:
vp createe2e test workflowvp createwithVP_OVERRIDE_PACKAGES/VP_VERSIONpointing to local packagesvite-plus@0.0.0installed,vp check, and build/test commandsvp run readytwice and assert 100% cache hit on the second runtest: create-e2elabel, or create-related file changesFix: bun monorepo catalog with
file:protocolrewriteBunCatalog()unconditionally set all overrides tocatalog:but skippedfile:entries from the catalog, leaving unresolvable referencesfile:paths directly in overrides when the value starts withfile:Fix: yarn standalone projects
rewriteYarnrcYml()now setsnodeLinker: node-moduleswhen absent (yarn 4 defaults to PnP)rewriteStandaloneProject()now callsrewriteYarnrcYml()for yarn projects (previously only called for monorepos)vp createpasses--no-frozen-lockfiletovp installin CI environmentsTest plan
vp test run packages/cli/src/migration/)bun-catalog-file-protocol.spec.tstest verifies the bun override fix🤖 Generated with Claude Code