fix: more safer Vite+ global install and vp upgrade#1338
Merged
fengmk2 merged 5 commits intovoidzero-dev:mainfrom Apr 8, 2026
Merged
fix: more safer Vite+ global install and vp upgrade#1338fengmk2 merged 5 commits intovoidzero-dev:mainfrom
vp upgrade#1338fengmk2 merged 5 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
|
@cpojer @TheAlexLichter Should the first-time installation of Vite+ follow this config as well? Wouldn’t that feel a bit strange? |
Member
|
Yes, I would honor the settings for the first time install as well. |
fengmk2
approved these changes
Apr 8, 2026
Member
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63c54eb115
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
related issues and PRs
vp upgradefails whenminimumReleaseAgeis configured #1260vp upgrade#1272curl -fsSL https://vite.plus | bashfails silently whenvp installencounters an error #833This updates the release-age handling for the Vite+ global install/upgrade path so we no longer silently bypass package manager protections.
Users who configure pnpm
minimumReleaseAgeare explicitly trying to reduce supply-chain risk from newly published compromised packages.Instead of always writing
minimum-release-age=0, Vite+ now first runs the wrapper install normally.If pnpm blocks the install with a release-age error, Vite+ only writes the local override and retries after an interactive, default-No confirmation.
The same behavior is applied to the standalone install scripts, including
install.ps1andinstall.sh.Changes
minimum-release-age=0override fromvp upgradeand standalone installers.ERR_PNPM_NO_MATURE_MATCHING_VERSION,minimumReleaseAgemessages, and guardedERR_PNPM_NO_MATCHING_VERSIONcases.install.log/upgrade.logvisibility for failure diagnosis.--silentto the inner capturedvp install, because pnpm suppresses the release-age error body in silent mode.