Skip to content

Assert proposal number matches PR number #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gatesn merged 1 commit into from
Feb 28, 2026
Merged

Assert proposal number matches PR number #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,35 @@ jobs:
- name: Install dependencies
run: bun install

- name: Check proposal matches PR number
run: |
BASE_SHA="${{ github.event.pull_request.base.sha }}"
HEAD_SHA="${{ github.event.pull_request.head.sha }}"
PR_NUMBER="${{ github.event.pull_request.number }}"

CHANGED_PROPOSALS=$(git diff --name-only "$BASE_SHA" "$HEAD_SHA" -- 'proposals/' \
| grep -v '^proposals/0000-template\.md$' || true)

COUNT=$(echo "$CHANGED_PROPOSALS" | grep -c . || true)

if [ "$COUNT" -gt 1 ]; then
echo "::error::PR touches $COUNT proposals. Only one proposal per PR is allowed."
echo "$CHANGED_PROPOSALS"
exit 1
fi

if [ "$COUNT" -eq 1 ]; then
FILE=$(echo "$CHANGED_PROPOSALS" | head -1)
FILENAME=$(basename "$FILE")
FILE_NUMBER=$(echo "$FILENAME" | grep -oE '^[0-9]+' || true)
# Strip leading zeros for comparison
FILE_NUM=$((10#$FILE_NUMBER))

if [ "$FILE_NUM" -ne "$PR_NUMBER" ]; then
echo "::error::Proposal number ($FILE_NUM from $FILENAME) does not match PR number ($PR_NUMBER)."
exit 1
fi
fi

- name: Build
run: bun run build