Skip to content

Remove duplicate ValidityVTable logic #5975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gatesn merged 18 commits into from
Jan 19, 2026

Fix is not null

48dd238
Select commit
Loading
Failed to load commit list.
Merged

Remove duplicate ValidityVTable logic #5975

Fix is not null
48dd238
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Jan 19, 2026

Performance Regression: -35.79%

⚡ 39 improved benchmarks
❌ 47 regressed benchmarks
✅ 1168 untouched benchmarks
⏩ 1254 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation chunked_opt_bool_canonical_into[(100, 100)] 210.1 µs 281.4 µs -25.36%
❌ Simulation chunked_opt_bool_canonical_into[(1000, 10)] 72.4 µs 83.3 µs -13.16%
❌ Simulation chunked_opt_bool_into_canonical[(1000, 10)] 73.3 µs 84.2 µs -12.95%
⚡ Simulation bench_compare_primitive[(10000, 512)] 189.6 µs 171.2 µs +10.75%
⚡ Simulation bench_compare_primitive[(10000, 2)] 171.1 µs 152.6 µs +12.08%
⚡ Simulation bench_compare_primitive[(10000, 128)] 174.4 µs 156.8 µs +11.25%
❌ Simulation chunked_opt_bool_into_canonical[(100, 100)] 211 µs 281.7 µs -25.1%
⚡ Simulation bench_compare_primitive[(10000, 32)] 171.9 µs 153.6 µs +11.91%
⚡ Simulation bench_compare_primitive[(10000, 4)] 171.5 µs 152 µs +12.81%
⚡ Simulation bench_compare_primitive[(100000, 2)] 980.7 µs 789.8 µs +24.17%
❌ Simulation chunked_varbinview_opt_canonical_into[(10, 1000)] 3.2 ms 4 ms -18.82%
⚡ Simulation bench_compare_primitive[(100000, 128)] 984.2 µs 794.3 µs +23.91%
⚡ Simulation bench_compare_primitive[(10000, 8)] 170.3 µs 152 µs +12.07%
❌ Simulation chunked_varbinview_opt_canonical_into[(100, 100)] 2 ms 2.2 ms -10.49%
❌ Simulation chunked_varbinview_opt_into_canonical[(10, 1000)] 3.3 ms 4 ms -18.54%
⚡ Simulation bench_compare_primitive[(100000, 2048)] 1,083.3 µs 893.7 µs +21.21%
⚡ Simulation bench_compare_primitive[(100000, 32)] 981.1 µs 791.6 µs +23.94%
⚡ Simulation bench_compare_primitive[(100000, 512)] 1,042.1 µs 852 µs +22.31%
⚡ Simulation bench_compare_primitive[(100000, 4)] 979.8 µs 789.7 µs +24.08%
❌ Simulation chunked_varbinview_opt_into_canonical[(100, 100)] 2 ms 2.2 ms -10.45%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Comparing ngates/remove-duplicate-validity-logic (48dd238) with develop (49d77a2)

Open in CodSpeed

Footnotes

  1. 1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

View more details on CodSpeed HQ