Skip to content

fix: don't commit to case when binary format#6806

Merged
joseph-isaacs merged 4 commits intodevelopfrom
ji/fixup-case-when
Mar 6, 2026
Merged

fix: don't commit to case when binary format#6806
joseph-isaacs merged 4 commits intodevelopfrom
ji/fixup-case-when

Conversation

@joseph-isaacs
Copy link
Contributor

We want to bad the serialisation of expr incase we which to change the format

@joseph-isaacs joseph-isaacs changed the title fix: don't commit to case when bin format fix: don't commit to case when binary format Mar 5, 2026
@joseph-isaacs joseph-isaacs marked this pull request as ready for review March 5, 2026 16:58
@joseph-isaacs joseph-isaacs added the changelog/fix A bug fix label Mar 5, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@palaska
Copy link
Contributor

palaska commented Mar 6, 2026

@joseph-isaacs is this good to go?

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 6, 2026

Merging this PR will improve performance by 24.83%

⚡ 3 improved benchmarks
✅ 391 untouched benchmarks
⏩ 2052 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 0.5)] 2.6 ms 2.1 ms +24.83%
Simulation take_map[(0.1, 0.1)] 1,007.5 µs 910.7 µs +10.63%
Simulation take_map[(0.1, 1.0)] 4.2 ms 3.5 ms +20.33%

Comparing ji/fixup-case-when (5f30b61) with develop (5d6a3c8)2

Open in CodSpeed

Footnotes

  1. 2052 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (075870d) during the generation of this report, so 5d6a3c8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs merged commit 51d30c5 into develop Mar 6, 2026
43 of 48 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/fixup-case-when branch March 6, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants