Skip to content

No longer need to install visual studio for windows machines#6827

Open
robert3005 wants to merge 1 commit intodevelopfrom
rk/windows-full
Open

No longer need to install visual studio for windows machines#6827
robert3005 wants to merge 1 commit intodevelopfrom
rk/windows-full

Conversation

@robert3005
Copy link
Contributor

Signed-off-by: Robert Kruszewski github@robertk.io

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/chore A trivial change label Mar 6, 2026
Copy link
Contributor

@a10y a10y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@robert3005
Copy link
Contributor Author

seems that we are ahead of the curve and this is not built yet, the pr only got merged like 40 mins ago

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 6, 2026

Merging this PR will improve performance by 27.46%

⚡ 3 improved benchmarks
✅ 391 untouched benchmarks
⏩ 2052 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 0.1)] 1,007.5 µs 907 µs +11.08%
Simulation take_map[(0.1, 0.5)] 2.6 ms 2 ms +27.46%
Simulation take_map[(0.1, 1.0)] 4.2 ms 3.5 ms +20.57%

Comparing rk/windows-full (e6143eb) with develop (5d6a3c8)2

Open in CodSpeed

Footnotes

  1. 2052 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (60476a9) during the generation of this report, so 5d6a3c8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Contributor

@joseph-isaacs joseph-isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't work

@robert3005
Copy link
Contributor Author

we need a new release here https://github.com/runs-on/runner-images-for-aws/releases

@robert3005 robert3005 added the do not merge Pull requests that are not intended to merge label Mar 6, 2026
@joseph-isaacs
Copy link
Contributor

can we do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change do not merge Pull requests that are not intended to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants