Skip to content

Auto-vectorize pure-fixed offsets construction #7997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joseph-isaacs wants to merge 1 commit into from
Closed

Auto-vectorize pure-fixed offsets construction #7997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions vortex-row/src/encode.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,16 @@ fn execute_row_encode(
let mut listview_offsets: Vec<u32> = Vec::with_capacity(nrows);
match var_lengths.as_ref() {
None => {
for i in 0..nrows {
listview_offsets.push(
(i as u32)
.checked_mul(fixed_per_row)
.vortex_expect("row offset overflow (already validated total fits in u32)"),
);
// Pure-fixed: offsets[i] = i * fixed_per_row. Materialize via a tight
// pointer-write loop that LLVM auto-vectorizes; we already validated total
// fits in u32 above so the multiplications can't overflow.
// SAFETY: reserved nrows; pointers within [0, nrows) are valid.
unsafe {
let ptr = listview_offsets.as_mut_ptr();
for i in 0..nrows {
ptr.add(i).write((i as u32) * fixed_per_row);
}
listview_offsets.set_len(nrows);
}
}
Some(v) => {
Expand Down
Loading