Fuzzing Crash: unknown in file_io#8018
Open
vortex-claude[bot] wants to merge 1 commit into
Open
Conversation
When arrow_compare_arrays falls back to make_comparator for nested types (struct, list, etc.), both sides were independently converted to Arrow with target=None, letting each array choose its own nearest physical type. A struct child backed by VarBinArray would produce Binary while a VarBinViewArray child would produce BinaryView. Both represent the same logical DType::Binary, but the assert_eq! on the data types panicked. Fix: convert lhs first (target=None) then use its Arrow DataType as the target Field when converting rhs. This mirrors the non-nested fast path which uses Datum::try_new_with_target_datatype for the same reason, and removes the now-redundant assert. Add a regression test that directly reproduces the fuzz crash pattern: a struct with a VarBinArray child on the left and a VarBinViewArray child on the right. Fixes #7957 Signed-off-by: Claude <claude@anthropic.com> Co-authored-by: Joe Isaacs <joseph-isaacs@users.noreply.github.com>
robert3005
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7957
Generated with Claude Code.
View Claude run