Skip to content

Fallback from fsst specialised like expression if there are escape characters in the like string#8038

Open
robert3005 wants to merge 1 commit into
developfrom
rk/likepushdown
Open

Fallback from fsst specialised like expression if there are escape characters in the like string#8038
robert3005 wants to merge 1 commit into
developfrom
rk/likepushdown

Conversation

@robert3005
Copy link
Copy Markdown
Contributor

@robert3005 robert3005 commented May 20, 2026

"\" is the escape character but we might need to specialise it in the future to
arbitrary symbols

fix #8027

…aracters in the like string

Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 20, 2026

Merging this PR will degrade performance by 16.59%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 1 regressed benchmark
✅ 1236 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 187.7 µs 225.1 µs -16.59%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/likepushdown (b3be114) with develop (008c1d9)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Like evaluation for fsst is incorrect if the pattern constains escape sequences

1 participant