Skip to content

Execution rule for Chunked<ParquetVariant>#8039

Open
AdamGS wants to merge 1 commit into
developfrom
adamg/chunked-parquet-variant
Open

Execution rule for Chunked<ParquetVariant>#8039
AdamGS wants to merge 1 commit into
developfrom
adamg/chunked-parquet-variant

Conversation

@AdamGS
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS commented May 20, 2026

Summary

When we have Chunked array, we can (sometimes) keep it as a ParquetVariant array instead of just shifting the ChunkedArray into a canonical Variant array's core storage child.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS added the changelog/feature A new feature label May 20, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 20, 2026

Merging this PR will degrade performance by 16.59%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 1 regressed benchmark
✅ 1236 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 187.7 µs 225.1 µs -16.59%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/chunked-parquet-variant (133ec1d) with develop (008c1d9)

Open in CodSpeed

@robert3005
Copy link
Copy Markdown
Contributor

@joseph-isaacs has done quite a bit of work on Chunked execution. Maybe we should do the swizzling in the builder execution mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants