Skip to content

Explicit Precision::Absent variant instead of Option<Precision> #8042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdamGS wants to merge 9 commits into
base: develop
Choose a base branch
from

Revert on-disk change

5ebeb8b
Select commit
Loading
Failed to load commit list.
Open

Explicit Precision::Absent variant instead of Option<Precision> #8042

Revert on-disk change
5ebeb8b
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed May 20, 2026 in 0s

1 benchmark regressed

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 1235 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation chunked_varbinview_canonical_into[(100, 100)] 273.1 µs 308.8 µs -11.56%
⚡ Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 224.9 µs 188.2 µs +19.47%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing adamg/absent-precision-variant (5ebeb8b) with develop (19a1fb3)

Open in CodSpeed
View more details on CodSpeed HQ