Open
Conversation
…textprotocol#731) * fix: include granted scopes in OAuth refresh token request * docs: document scope forwarding in token refresh flow
This reverts commit 2cd946e.
peicodes
changed the title
vorporeal
reviewed
Mar 31, 2026
Comment on lines
+1477
to
+1492
| // Test URL with single path segment: follow spec priority order | ||
| let base_url = Url::parse("https://auth.example.com/tenant1").unwrap(); | ||
| let urls = AuthorizationManager::generate_discovery_urls(&base_url); | ||
| assert_eq!(urls.len(), 3); | ||
| assert_eq!( | ||
| urls[0].as_str(), | ||
| "https://auth.example.com/.well-known/oauth-authorization-server/tenant1" | ||
| ); | ||
| assert_eq!( | ||
| urls[1].as_str(), | ||
| "https://auth.example.com/.well-known/openid-configuration/tenant1" | ||
| ); | ||
| assert_eq!( | ||
| urls[2].as_str(), | ||
| "https://auth.example.com/tenant1/.well-known/openid-configuration" | ||
| ); |
There was a problem hiding this comment.
i'm a bit worried that this actually breaks some non-spec-compliant MCP servers. i believe that there are some which have /mcp in the server path, but don't include that in any form in the oauth authorization server URL.
which/how many MCP servers did you test with? i think either linear or sentry might break (based on my memory of when i was trying to update us to upstream).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in:
Hoping these are sufficient to fix the frequent refresh issues we've been seeing with MCP.
I tested this branch locally against warp-internal to ensure core mcp functionality still works