first definition of "first day", and minor doc mod

[sawka]

No description provided.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request updates documentation for AI-compatible configuration: renames the credential field from ai:apitoken to ai:apitokensecretname, changes ai:mode references to ai:apitype, adds an ai:capabilities field, and clarifies that ai:apitokensecretname should name an environment variable containing the API key to be set before running Wave Terminal. Separately, telemetry.RecordTEvent now sets AppFirstDay by comparing calendar date (year, month, day) with the TOS agreement timestamp, treating missing TOS timestamp as first-day.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess whether the description relates to the changeset.	Add a pull request description explaining the changes, including the rationale for the 'first day' definition update and documentation modifications.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main changes: implementing a definition of 'first day' based on calendar day rather than 24-hour window, and updating documentation for API configuration.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@docs/docs/waveai-modes.mdx`:
- Around line 202-203: Fix the typo in the docs by replacing the phrase "OpenAPI
compatible API provider" with "OpenAI compatible API provider" (the sentence
referencing ai:endpoint, ai:apitokensecretname, ai:model and ai:apitype set to
"openai-chat"); ensure any other occurrences of "OpenAPI" in this section/header
are changed to "OpenAI" so the header "OpenAI Compatible" and body text match.

🧹 Nitpick comments (1)

docs/docs/waveai-modes.mdx (1)

206-207: Minor: "baseurl" should be "base URL".

Per standard spelling, "base URL" is two words.

📝 Proposed fix

-The ai:endpoint is *NOT* a baseurl. The endpoint should contain the full endpoint, not just the baseurl.
+The ai:endpoint is *NOT* a base URL. The endpoint should contain the full endpoint, not just the base URL.