Skip to content

fix for #2818 (dont let empty plotData go to SingleLinePlot)#2827

Merged
sawka merged 1 commit intomainfrom
sawka/sysinfo-fix
Feb 5, 2026
Merged

fix for #2818 (dont let empty plotData go to SingleLinePlot)#2827
sawka merged 1 commit intomainfrom
sawka/sysinfo-fix

Conversation

@sawka
Copy link
Member

@sawka sawka commented Feb 5, 2026

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

Walkthrough

A conditional guard was added to the sysinfo.tsx file to prevent rendering of series plots in the SysinfoViewInner component. The yvals mapping operation is now prefixed with a condition that checks if plotData exists and has a length greater than 0. This prevents SingleLinePlot components from being rendered when no plot data is available.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess whether it relates to the changeset. Add a pull request description explaining the issue, the fix, and any relevant testing or context for reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly references a specific issue (#2818) and describes the main fix: preventing empty plotData from being passed to SingleLinePlot.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sawka/sysinfo-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sawka sawka merged commit b882e38 into main Feb 5, 2026
7 checks passed
@sawka sawka deleted the sawka/sysinfo-fix branch February 5, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant