[Gecko Bug 2005895] Make AutoEmptyBlockAncestorDeleter::GetNewCaretPosition() never return point after a line break before a block boundary
#56848
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urn point after a line break before a block boundary The caret should be put before the last line break in a block if there is no visible content between the line break and the end block boundary. Additionally, `WhiteSpaceVisibilityKeeper::DeleteContentNodeAndJoinTextNodesAroundIt()` should delete the preceding block's invisible `<br>` too. Differential Revision: https://phabricator.services.mozilla.com/D276756 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2005895 gecko-commit: 8cb2cca1db5ad41200028ec41d8e7a87eee58e82 gecko-reviewers: m_kato
wpt-pr-bot
approved these changes
Dec 18, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caret should be put before the last line break in a block if there
is no visible content between the line break and the end block boundary.
Additionally,
WhiteSpaceVisibilityKeeper::DeleteContentNodeAndJoinTextNodesAroundIt()should delete the preceding block's invisible
<br>too.Differential Revision: https://phabricator.services.mozilla.com/D276756
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2005895
gecko-commit: 8cb2cca1db5ad41200028ec41d8e7a87eee58e82
gecko-reviewers: m_kato