[Gecko Bug 2006402] Properly resolve auto inset/margin in nsComputedDOMStyle with anchor positioning. #56858
+120
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…positioning. Differential Revision: https://phabricator.services.mozilla.com/D276908 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2006402 gecko-commit: fd956d5f37d157ae16c9cc7c7ac80f9f38621c31 gecko-reviewers: layout-anchor-positioning-reviewers, firefox-style-system-reviewers, emilio
wpt-pr-bot
approved these changes
Dec 18, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
…DOMStyle with anchor positioning. " for causing build bustages @nsStyleStruct.cpp. This reverts commit 6e861d0db3e83e4c7c0aa74dc422b02d7514bbbf. Revert "Bug 2006402: Use physical axes for flagging anchor-center use. r=layout-anchor-positioning-reviewers,firefox-style-system-reviewers,emilio" This reverts commit 56907edbced39dadadc4779d62eb9dee4bedb755. Revert "Bug 2006402: Remove anchor-center flags in reflowinput. r=layout-anchor-positioning-reviewers,layout-reviewers,emilio" This reverts commit 3d67a1059f6f1b8b698a45fcea4f513bc4917b40. Revert "Bug 2006402: Ensure that we override auto insets/margins only when there's position-area/anchor-center + valid default anchor. r=layout-anchor-positioning-reviewers,firefox-style-system-reviewers,layout-reviewers,emilio" This reverts commit 8e1950452fbb5138d50c252ae3189de14b088a47. gecko-commit: 199c3640e23d78b269c6810dd894d4593995b455 gecko-reviewers: layout-anchor-positioning-reviewers, firefox-style-system-reviewers, emilio
…positioning. Differential Revision: https://phabricator.services.mozilla.com/D276908 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2006402 gecko-commit: 309caa4f36b47af6c3a1950e79c7a62363f9e098 gecko-reviewers: layout-anchor-positioning-reviewers, firefox-style-system-reviewers, emilio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: https://phabricator.services.mozilla.com/D276908
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2006402
gecko-commit: fd956d5f37d157ae16c9cc7c7ac80f9f38621c31
gecko-reviewers: layout-anchor-positioning-reviewers, firefox-style-system-reviewers, emilio