Skip to content

Remove Chromium note in serialization algorithm #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domfarolino merged 1 commit into from
Mar 3, 2026
Merged

Remove Chromium note in serialization algorithm #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,16 +251,11 @@ The <dfn method for=ModelContext>registerTool(<var>tool</var>)</dfn> method step
<li><p><i>Throws a new {{TypeError}}</i> when the backing "<code>JSON.stringify()</code>"
yields undefined, e.g.,
"<code>inputSchema: { toJSON() {return HTMLDivElement;}}</code>", or
"<code>innputSchema: { toJSON() {return undefined;}}</code>".</p></li>
"<code>inputSchema: { toJSON() {return undefined;}}</code>".</p></li>

<li><p><i>Re-throws exceptions</i> thrown by "<code>JSON.stringify()</code>", e.g., when
"<code>inputSchema</code>" is an object with a circular reference, etc.</p></li>
</ol>

<p class="XXX">Currently, the only implementation of this spec (Chromium) does not throw
exceptions in the first case above. And for the second case, Chromium throws new {{TypeError}}
exceptions, as opposed to <em>re-throwing</em> the original exception. We <span
class=allow-2119>should</span> reconcile this difference.</p>
</div>

1. Let |read-only hint| be true if |tool|'s {{ModelContextTool/annotations}} [=map/exists=], and if
Expand Down