Draft
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to close #5368
In order to replace chokidars removed glob functionality, we have to use some trickery.
glob-parentis used to get the common ancenstor dir that needs to be watched.picomatchis used as ignore-filter to make sure that only files/dirs are watched that match the given globis-globis used to only use glob logic when neededIn total this adds 4 direct or transitive dependencies. However, the update to chokidar v4 removes 12. So its a net positive
I also added a test to ensure that creation of nested directories is detected properly.
NOTE: This PR needs to wait for paulmillr/chokidar#1394. If that issue is not resolved, we have to make sure to not let undefined values slip through for watcher options.
I didn't add this change to this PR because it would add more changed lined and it might be not needed after all.
That's why this PR is still draft