feat: plugin support by bjohansebas · Pull Request #5650 · webpack/webpack-dev-server

bjohansebas · 2026-02-21T18:16:50Z

Summary

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

If relevant, what needs to be documented once your changes are merged or what have you already documented?

codecov · 2026-02-21T18:19:51Z

Codecov Report

❌ Patch coverage is 97.54098% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.08%. Comparing base (28ecc85) to head (2d6d746).

Files with missing lines	Patch %	Lines
lib/Server.js	97.54%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #5650      +/-   ##
==========================================
+ Coverage   88.85%   89.08%   +0.23%     
==========================================
  Files          13       13              
  Lines        5893     5999     +106     
==========================================
+ Hits         5236     5344     +108     
+ Misses        657      655       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

alexander-akait · 2026-02-21T19:06:48Z

We should start it in webpack-dev-middleware, currently webpack-dev-middleware uses console.log to output stats, it means we will spam logs, we need an options or another function wrapper - require("webpack-dev-middleware").plugin(options)

bjohansebas

These changes should work without requiring any changes to webpack-cli yet. Once this is merged, we can work on a patch for webpack-cli to use the plugin support, but it is independent of changes to webpack-cli.

bjohansebas · 2026-05-07T05:55:44Z

cc: @alexander-akait friendly ping for feedback

alexander-akait · 2026-05-08T15:17:30Z

Will look soon, I little bit busy, we should make the new major release the next week, I will help you to finish remains tasks

alexander-akait · 2026-05-11T16:31:45Z

@bjohansebas let's rebase

alexander-akait · 2026-05-18T15:28:21Z

@bjohansebas can take a look at our failed tests, a lot of PRs without green, we need to resolve it, thanks

bjohansebas · 2026-05-22T05:24:13Z

@bjohansebas can take a look at our failed tests, a lot of PRs without green, we need to resolve it, thanks

Those are just flaky tests, like before. You just need to rerun them and that's it.

alexander-akait · 2026-05-22T08:57:15Z

Looks like problem with lint here

* feat!: drop support for node <20.9 * feat: update baseline-browser-mapping to version 2.9.16 * chore: remove baseline-browser-mapping dependency

* chore: remove SockJSClient and related files from the project * chore: remove SockJS support and related configurations from the project * chore: remove SockJS example files and configurations * chore: remove SockJS support and related tests from the project * refactor: change sockjs to ws for customclient * fix: update import typedef * fix: update snapshots Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com> * chore: remove SockJS and related type definitions from package.json and package-lock.json * refactor: simplify WebSocket session handling in tests * test: update WebSocket handling in client tests to use CDP sessions * fix: update snapshot for SSL certificate generation log in server options test * docs: update migration guide to reflect removal of SockJS support * refactor: remove SockJS dependency from CustomWebSocketClient * chore: update puppeteer to version 24.35.0 in package.json * fix: update import path for webpack config in client tests * fix: update createCDPSession usage in client tests * refactor: update session creation and subscription handling in tests * fix: update webSocketTransport configuration to include webSocketURL and host --------- Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

* feat: bump to express 5 Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com> * fix: update webpack-dev-middleware to version 7.4.5 and adjust snapshot for response headers * test: remove TODO comment regarding content-type in range-header test * refactor: simplify logger assignment in proxy * test: update expectation for error logging in proxy option test * test: mock console.error for proxy option tests and verify error logging * refactor: replace logger string with server.logger in allowed hosts tests * refactor: update proxy middleware to use 'on' object for request handling * docs: update migration guide to clarify proxy options changes --------- Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

* feat: remove spdy support * docs: update migration guide to remove spdy server type support

* test: remove async bypass handling from proxy options the router does not allow sending data the way bypass did. In the router we only have the req object, so this test is removed since it is invalid (https://github.com/chimurai/http-proxy-middleware/blob/6436ffc522a3a2485c198bd2fb544db0e33e3821/src/router.ts#L7) * test: remove another test Just like in the previous commit, the router, or any other handler ,does not allow sending data; it only changes where the request should be forwarded via the proxy. Therefore, it doesn’t make sense to keep this test. * test: remove deprecated bypass option tests * test: use only pathRewrite * feat: remove deprecated bypass option from proxy configuration * test: improve tests * test: update pathFilter in proxy option tests * docs: update migration guide to reflect removal of bypass function in proxy configuration * chore: update examples * fixup! * docs: update migration guide to clarify minimum webpack version requirement

* feat: use compiler.platform to determine the target * feat: update WebSocket communication conditions and multi-compiler fallback logic * chore: update qs package to version 6.15.0 * fixup!

…avior

…n shutdown

…pilation

…ests

… port mapping

…guration

…ng in Server class

alexander-akait · 2026-06-04T15:20:06Z

+    // the user is not in control of the plugin lifecycle here, so we stay
+    // silent rather than logging a warning.
+    const isBuildMode = () =>
+      childCompilers.every((child) => !child.watching && !child.options.watch);


Each compiler have watching when it is watching, no need to check on watch, at least I can see situation when watch will be true, but watching undefined

alexander-akait · 2026-06-04T15:20:34Z

+      if (seenFirstDone.has(childCompiler)) return;
+      seenFirstDone.add(childCompiler);
+      firstDoneCount++;
+      if (firstDoneCount < childCompilers.length) return;


Can you clarify when we need firstDoneCount?

alexander-akait · 2026-06-04T15:22:03Z

+      childCompiler.hooks.done.tapPromise(pluginName, () =>
+        onChildDone(childCompiler),
+      );
+      childCompiler.hooks.shutdown.tapPromise(pluginName, onChildShutdown);


Ideally we should have the same hooks for multi compiler, and so don't use for/of, but we can postpone it and improve later

alexander-akait · 2026-06-04T15:22:33Z

+    };
+
+    for (const childCompiler of childCompilers) {
+      childCompiler.hooks.beforeCompile.tapPromise(pluginName, ensureSetup);


Can we avoid beforeCompile at all, it is unsafe in some cases, ideally we should use only done and shutdown

I think we can done everything on done, also please add a test case what we really change outputFileSystem and use it, not webpack built-in the real fs

bjohansebas · 2026-06-09T14:01:00Z

okay tomorrow i will continue with this

…ng state

bjohansebas force-pushed the plugin-support branch from 0d79407 to 8664549 Compare March 30, 2026 19:43

alexander-akait reviewed Mar 31, 2026

View reviewed changes

Comment thread lib/Server.js Outdated

alexander-akait reviewed Mar 31, 2026

View reviewed changes

Comment thread lib/Server.js Outdated

bjohansebas force-pushed the plugin-support branch from d8084a7 to 9890a76 Compare April 1, 2026 23:07

alexander-akait reviewed Apr 2, 2026

View reviewed changes

Comment thread test/e2e/api.test.js Outdated

bjohansebas force-pushed the plugin-support branch from 9890a76 to 616b803 Compare April 26, 2026 18:50

bjohansebas marked this pull request as ready for review May 1, 2026 20:49

bjohansebas requested a review from alexander-akait May 1, 2026 21:07

bjohansebas commented May 1, 2026

View reviewed changes

bjohansebas force-pushed the plugin-support branch 2 times, most recently from 1060a9c to 4591762 Compare May 16, 2026 17:54

bjohansebas force-pushed the plugin-support branch from bb3626c to 9912722 Compare May 22, 2026 05:07

bjohansebas added 10 commits May 23, 2026 11:01

feat!: remove internalIP methods (#5625)

9f24874

feat!: drop support for node <20.9 (#5631)

ad1201a

* feat!: drop support for node <20.9 * feat: update baseline-browser-mapping to version 2.9.16 * chore: remove baseline-browser-mapping dependency

feat: remove spdy (#5635)

8a51cae

* feat: remove spdy support * docs: update migration guide to remove spdy server type support

feat: enable compression middleware for http/2 (#5638)

e410dea

feat: use new URL instead of url.parse (#5637)

3ca084f

feat: remove colorette dependency (#5642)

b040f0f

feat: use compiler.platform to determine the target (#5647)

97716d3

* feat: use compiler.platform to determine the target * feat: update WebSocket communication conditions and multi-compiler fallback logic * chore: update qs package to version 6.15.0 * fixup!

bjohansebas added 21 commits May 23, 2026 13:52

feat: adapt webpack-dev-middleware.plugin

0823749

feat: enhance plugin API support and update tests for new compile beh…

3a74303

…avior

feat: add isPlugin flag to Server class for plugin identification

645e209

feat: prevent multiple server starts on recompilation and ensure clea…

9835cee

…n shutdown

fixup!

f52bb79

chore: more tests

b597f61

feat: enhance server setup process

f77edd9

refactor: remove unnecessary compiler checks in setup methods

a1d3ef3

test: ensure server setup and listen methods are called once on recom…

00af8c1

…pilation

test: add API plugin tests and snapshots for webpack config integration

97df084

feat: enhance MultiCompiler support in server setup and add related t…

95d10c0

…ests

feat: add support for multiple independent plugin servers and enhance…

01dd36f

… port mapping

test: add test for passive behavior in build mode with compiler.run

438b0d6

fixup!

6564733

feat: add example for using webpack-dev-server as a plugin with confi…

6c91186

…guration

refactor: update README and remove redundant standalone server handli…

3cbb12d

…ng in Server class

fixup!

5b9c8d2

test: add more tests

e7ff49e

fixup!

1cd55ba

fixup!

2573bf2

chore: convert to esm

2d6d746

bjohansebas force-pushed the plugin-support branch from 0102816 to 2d6d746 Compare May 23, 2026 18:52

alexander-akait reviewed Jun 4, 2026

View reviewed changes

fix: update build mode check to only consider child compilers' watchi…

b2914df

…ng state

bjohansebas force-pushed the next branch 2 times, most recently from c2dd24b to 4810909 Compare June 12, 2026 22:46

Uh oh!

Conversation

bjohansebas commented Feb 21, 2026

Uh oh!

codecov Bot commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

alexander-akait commented Feb 21, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bjohansebas left a comment

Choose a reason for hiding this comment

Uh oh!

bjohansebas commented May 7, 2026

Uh oh!

alexander-akait commented May 8, 2026

Uh oh!

alexander-akait commented May 11, 2026

Uh oh!

alexander-akait commented May 18, 2026

Uh oh!

bjohansebas commented May 22, 2026

Uh oh!

alexander-akait commented May 22, 2026

Uh oh!

alexander-akait Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

alexander-akait Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

alexander-akait Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

alexander-akait Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

alexander-akait Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

bjohansebas commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Feb 21, 2026 •

edited

Loading