This repository was archived by the owner on Oct 18, 2024. It is now read-only.
Fix issue for python3.9+ #19
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
fromstringmethod is removed since python 3.9. There was a note in previous versions to switch fromfromstringintofrombytes. here is the linkshttps://docs.python.org/3.8/library/array.html#array.array.frombytes
https://docs.python.org/3.8/library/array.html#array.array.fromstring
How to test
Test it in any py3.9 environment. clearly it is broken
How can we measure success?
N/A
Have we considered potential risks?
frombytesis available since python 3.2 but not older versions. so if someone still uses something older than 3.2,frombyteswon't work for him