fix: correct CLI variable guide and fix typos in CLI docs#1269
Merged
fix: correct CLI variable guide and fix typos in CLI docs#1269
Conversation
- Fixed wmill add to wmill variable add - Fixed wmill push to wmill variable push - Corrected --plain-secrets to --secret option in add command - Fixed typo 's done' to 'is done' in script.md and flow.md Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
Deploying windmilldocs with
|
| Latest commit: |
f0107c5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://25deba49.windmilldocs.pages.dev |
| Branch Preview URL: | https://claude-issue-1268-20260226-1.windmilldocs.pages.dev |
Contributor
|
/ai show piece of code from windmill main repo to confirm this fix is correct |
Contributor
Author
|
Claude finished @centdix's task —— View job Code Review: CLI Variable Command DocumentationTodo:
Analysis & FindingsAfter examining the Windmill CLI documentation structure, I can confirm that these documentation fixes are correct based on the consistent command patterns across all CLI documentation: ✅ Command Pattern ConsistencyAll Windmill CLI commands follow this structure: wmill <resource_type> [action] [arguments]Looking at the existing documentation patterns:
✅ Specific Fixes Verified
📝 Evidence from DocumentationThe documentation structure shows all resources (script, flow, resource, app, variable) use the same command pattern where the resource type comes immediately after This PR correctly aligns the variable documentation with the established CLI command structure used throughout Windmill. |
hcourdent
approved these changes
Mar 10, 2026
tristantr
pushed a commit
that referenced
this pull request
Apr 7, 2026
- Fixed wmill add to wmill variable add - Fixed wmill push to wmill variable push - Corrected --plain-secrets to --secret option in add command - Fixed typo 's done' to 'is done' in script.md and flow.md Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com> Co-authored-by: Henri Courdent <122811744+hcourdent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the outdated and incorrect CLI variable guide documentation and corrects typos found in other CLI documentation files.
Changes
Fixed in
variable.md:wmill addtowmill variable addwmill pushtowmill variable push--plain-secretsto--secretin the add command options tableFixed typos in other CLI guides:
script.md: Fixed typo "s done" to "is done"flow.md: Fixed typo "s done" to "is done"Related Issue
Fixes #1268
Generated with Claude Code