Skip to content

Prgn/feat/listen for issue comments#100

Merged
coriolinus merged 1 commit into
hackathon-2026from
prgn/feat/listen-for-issue-comments
Jun 18, 2026
Merged

Prgn/feat/listen for issue comments#100
coriolinus merged 1 commit into
hackathon-2026from
prgn/feat/listen-for-issue-comments

Conversation

@coriolinus

Copy link
Copy Markdown

Comments on the top-level PR emit issue comment events for historical reasons. This adds them to the set of events we want to listen to, so that we can emit messages when they come in.


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@coriolinus coriolinus requested a review from a team as a code owner June 18, 2026 13:55
@coriolinus coriolinus changed the base branch from main to hackathon-2026 June 18, 2026 13:58
@coriolinus coriolinus merged commit d2386ac into hackathon-2026 Jun 18, 2026
3 checks passed
@coriolinus coriolinus deleted the prgn/feat/listen-for-issue-comments branch June 18, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants