Skip to content

chore: reviews link directly to the review, not to the overall PR#98

Merged
coriolinus merged 1 commit into
hackathon-2026from
prgn/chore/link-directly-to-review
Jun 18, 2026
Merged

chore: reviews link directly to the review, not to the overall PR#98
coriolinus merged 1 commit into
hackathon-2026from
prgn/chore/link-directly-to-review

Conversation

@coriolinus

Copy link
Copy Markdown

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@coriolinus coriolinus requested a review from a team as a code owner June 18, 2026 13:25
@claude

claude Bot commented Jun 18, 2026

Copy link
Copy Markdown

PR Review: reviews link directly to the review, not the overall PR

Focused, well-scoped change — the intent is clear and the implementation is the idiomatic way to do it.

Code quality

  • Adding htmlUrl with @SerialName("html_url") is exactly consistent with the existing convention in PullRequest.kt and Comment.kt (both expose a non-nullable htmlUrl mapped from html_url). Good consistency.
  • The template swap from pullRequest.htmlUrl to review.htmlUrl cleanly delivers the stated goal: the link now anchors to the specific review (...#pullrequestreview-<id>) rather than the PR page.

Correctness / robustness

  • Making htmlUrl non-nullable with no default is safe here: GitHub's pull_request_review payload always includes html_url on the review object, and the test fixture (events/pull_request_review.submitted.json) already carries it, so deserialization will not break. This matches how PullRequest/Comment model the same field, so I'd keep it as-is rather than making it nullable.

Test coverage

  • No automated test renders this template against the fixture, so the behavior change (PR URL -> review URL) is not actually exercised by the suite. Not a blocker at this scope, but a small render-the-template assertion for pull_request_review.submitted would lock in the intended link target.
  • Minor / pre-existing: src/test/fixtures/messages/pull_request_review.submitted.txt appears stale relative to the current template — it renders a different format and still points at the PR URL, not the review anchor. It does not seem to be consumed by any test, but if it is meant to be the expected-output reference it is now doubly out of date and worth refreshing (or removing).

Security / Performance

  • No concerns. html_url is a GitHub-provided URL rendered into a Markdown link — no new untrusted-input surface beyond what the template already handles.

Verdict: LGTM. Suggested follow-ups: reconcile the stale .txt fixture, and optionally add a template-rendering test covering the new link target.

@coriolinus coriolinus merged commit 51dc971 into hackathon-2026 Jun 18, 2026
6 checks passed
@coriolinus coriolinus deleted the prgn/chore/link-directly-to-review branch June 18, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants