WPB-26118 add totalLimitBytes to cellsInternal config#5271
Open
battermann wants to merge 5 commits into
Open
Conversation
2582ea7 to
2f9c463
Compare
totalLimitBytes to cellsInternal config
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit team-wide storage quota (totalLimitBytes) to the cellsInternal feature-flag config, and updates defaults/docs/tests to reflect the split between team total limit and per-user quota.
Changes:
- Introduce
QuotaBytesand extendCellsStoragewith optionaltotalLimitBytesalongsideperUserQuotaBytes. - Update integration/stern tests and Galley integration config to use the new storage quota shape and defaults.
- Update documentation and changelog to describe the new fields and “negative means unlimited” semantics.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/stern/test/integration/API.hs | Updates stern integration test expectations and config updates to include totalLimitBytes and new quota representation. |
| services/galley/galley.integration.yaml | Adjusts integration environment defaults for cellsInternal.storage to include totalLimitBytes and set per-user quota to unlimited. |
| libs/wire-api/src/Wire/API/Team/Feature.hs | Adds QuotaBytes, extends CellsStorage, and updates default CellsInternalConfig storage settings and schemas. |
| integration/test/Test/FeatureFlags/Util.hs | Updates expected feature flag JSON fixtures for cellsInternal.storage to include the new fields. |
| integration/test/Test/FeatureFlags/CellsInternal.hs | Updates integration tests to send/verify new storage quota fields and semantics. |
| docs/src/developer/reference/config-options.md | Updates config docs for cellsInternal.storage to document totalLimitBytes and unlimited semantics. |
| changelog.d/1-api-changes/WPB-26118 | Records the API surface change for cellsInternal storage quotas in v17. |
blackheaven
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d