Skip to content

WPB-26118 add totalLimitBytes to cellsInternal config#5271

Open
battermann wants to merge 5 commits into
developfrom
WPB-26118-wire-server-data-introduce-the-quota-source-provider-config
Open

WPB-26118 add totalLimitBytes to cellsInternal config#5271
battermann wants to merge 5 commits into
developfrom
WPB-26118-wire-server-data-introduce-the-quota-source-provider-config

Conversation

@battermann

@battermann battermann commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann force-pushed the WPB-26118-wire-server-data-introduce-the-quota-source-provider-config branch from 2582ea7 to 2f9c463 Compare June 16, 2026 15:00
@battermann battermann changed the title WPB-26118 WPB-26118 add totalLimitBytes to cellsInternal config Jun 16, 2026
@battermann battermann marked this pull request as ready for review June 16, 2026 15:00
@battermann battermann requested review from a team as code owners June 16, 2026 15:00
@battermann battermann requested a review from Copilot June 16, 2026 15:01
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jun 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an explicit team-wide storage quota (totalLimitBytes) to the cellsInternal feature-flag config, and updates defaults/docs/tests to reflect the split between team total limit and per-user quota.

Changes:

  • Introduce QuotaBytes and extend CellsStorage with optional totalLimitBytes alongside perUserQuotaBytes.
  • Update integration/stern tests and Galley integration config to use the new storage quota shape and defaults.
  • Update documentation and changelog to describe the new fields and “negative means unlimited” semantics.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/stern/test/integration/API.hs Updates stern integration test expectations and config updates to include totalLimitBytes and new quota representation.
services/galley/galley.integration.yaml Adjusts integration environment defaults for cellsInternal.storage to include totalLimitBytes and set per-user quota to unlimited.
libs/wire-api/src/Wire/API/Team/Feature.hs Adds QuotaBytes, extends CellsStorage, and updates default CellsInternalConfig storage settings and schemas.
integration/test/Test/FeatureFlags/Util.hs Updates expected feature flag JSON fixtures for cellsInternal.storage to include the new fields.
integration/test/Test/FeatureFlags/CellsInternal.hs Updates integration tests to send/verify new storage quota fields and semantics.
docs/src/developer/reference/config-options.md Updates config docs for cellsInternal.storage to document totalLimitBytes and unlimited semantics.
changelog.d/1-api-changes/WPB-26118 Records the API surface change for cellsInternal storage quotas in v17.

Comment thread libs/wire-api/src/Wire/API/Team/Feature.hs
Comment thread integration/test/Test/FeatureFlags/CellsInternal.hs Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Comment thread docs/src/developer/reference/config-options.md

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comment thread libs/wire-api/src/Wire/API/Team/Feature.hs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants