[Hackaton] Introduce Web Push#5277
Open
blackheaven wants to merge 11 commits into
Open
Conversation
zebot
added
the
ok-to-test
blackheaven
force-pushed
the
gdifolco/hackaton/web-push
branch
from
f17e16f to
047d1a9
Compare
The gundeck-integration helm test pod mounts gundeck-config (whose configmap emits postgresqlPassword: /etc/wire/gundeck/secrets/pgPassword when gundeck.secrets.pgPassword is set) but did not mount the gundeck-secrets volume. This caused createEnv -> initPostgresPool -> initCredentials to fail with 'File doesn't exist' for the two tests that call withSettingsOverrides (storeNotificationsEvenWhenRedisIsDown, testRedisMigration). Mirrors the existing brig-secrets pattern in brig-integration.yaml and the earlier fixes in gundeck/deployment.yaml and integration/integration-integration.yaml.
blackheaven
force-pushed
the
gdifolco/hackaton/web-push
branch
from
047d1a9 to
8e05230
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d